Use RouterBasedStoreMetadataFetcher for Venice store discovery#228
Merged
Conversation
Code Coverage
|
Avoids store-name collision with logical-ddl.id, which also creates and drops LOGICAL.testevent. Venice 0.4.858 enforces a 6-hour graveyard cooldown between deleting a store and recreating one with the same name, so whichever Quidem test runs second was failing with HTTP 500 "Store 'testevent' was recently deleted and cannot be recreated yet".
srnand
force-pushed
the
srnand/may20_26/UseVeniceStoreMetadataFetcher
branch
from
3b8b1da to
3c6c2ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ControllerClientbased, cluster-by-cluster listing toRouterBasedStoreMetadataFetcher(single router/storescall).venice-commonandvenice-thin-clientto0.4.858, which is the first version exposingRouterBasedStoreMetadataFetcher.Tests