[Test]: Add test suite for Llama4 RoPE implementation#1004
Merged
Tcc0403 merged 1 commit intolinkedin:mainfrom Jan 12, 2026
Merged
[Test]: Add test suite for Llama4 RoPE implementation#1004Tcc0403 merged 1 commit intolinkedin:mainfrom
Tcc0403 merged 1 commit intolinkedin:mainfrom
Conversation
- Add test_llama4_rope.py with comprehensive test coverage - Test correctness against HuggingFace implementation (forward & backward) - Test functional vs class interface consistency - Support multiple configurations: different batch sizes, sequence lengths, head dimensions, and q/kv head ratios - Support both float32 and bfloat16 dtypes - Follow existing test patterns from test_rope.py
Contributor
Author
|
Test Result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardware Type: NVIDIA A100-SXM4-80GB
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence