Skip to content

Update checkstyle and fix the format issue#1071

Merged
Tcc0403 merged 1 commit intolinkedin:mainfrom
xuedinge233:checkstyle
Feb 5, 2026
Merged

Update checkstyle and fix the format issue#1071
Tcc0403 merged 1 commit intolinkedin:mainfrom
xuedinge233:checkstyle

Conversation

@xuedinge233
Copy link
Contributor

@xuedinge233 xuedinge233 commented Feb 5, 2026

Summary

  1. I found that the benchmark_fused_add_rms_norm.py format issue led to the collective failure of CI. fix it first.
  2. The checkstyle script has been updated to enable it to display the modified logs.

Test

>> make checkstyle
ruff check --output-format=concise .; ruff_check_status=$?; \
        ruff format --check --diff .; ruff_format_status=$?; \
        ruff check . --fix; \
        ruff format .; \
        if [ $ruff_check_status -ne 0 ] || [ $ruff_format_status -ne 0 ]; then \
                exit 1; \
        fi
All checks passed!
--- benchmark/scripts/benchmark_fused_add_rms_norm.py
+++ benchmark/scripts/benchmark_fused_add_rms_norm.py
@@ -103,7 +103,7 @@
     elif mode == "backward":
         y, s = y_fwd()
         ms_50, ms_20, ms_80 = triton.testing.do_bench(
-            lambda: (torch.autograd.backward((y, s), (dy, ds), retain_graph=True)),
+            lambda: torch.autograd.backward((y, s), (dy, ds), retain_graph=True),
             grad_to_none=[x, r],
             rep=500,
             quantiles=QUANTILES,

1 file would be reformatted, 226 files already formatted
All checks passed!
1 file reformatted, 226 files left unchanged
make: *** [checkstyle] Error 1

Copy link
Collaborator

@Tcc0403 Tcc0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Tcc0403 Tcc0403 merged commit 1fdb668 into linkedin:main Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants