[NPU] Add support for the grpo_loss#1146
Merged
Tcc0403 merged 6 commits intolinkedin:mainfrom Mar 18, 2026
Merged
Conversation
UserChen666
changed the title
UserChen666
force-pushed
the
grpo_loss
branch
2 times, most recently
from
8741d26 to
d01d8e1
Compare
Contributor
Author
|
@Tcc0403 please review |
Tcc0403
reviewed
Mar 15, 2026
Collaborator
Tcc0403
left a comment
Tcc0403
left a comment
There was a problem hiding this comment.
lgtm, could you attach testing results in the comment?
Contributor
Author
test cases passed @Tcc0403
|
3 tasks
Tcc0403
previously approved these changes
Mar 17, 2026
auto-merge was automatically disabled
March 18, 2026 02:43
Head branch was pushed to by a user without write access
Collaborator
|
please resolve conflict |
Contributor
Author
all resolved |
Tcc0403
approved these changes
Mar 18, 2026
fix imports in __init__.py
Contributor
Author
done. |
Contributor
Author
|
Something wrong with my IDE, so I made some mistakes when I git |
Collaborator
|
No worries! It happens to me sometimes. Kind reminder, you can install pre-commit hook via pre-commit/prek for formatting and linting before commits. See: https://github.com/linkedin/Liger-Kernel/blob/main/docs/contributing.md#setting-up-your-development-environment we should probably update our PR template to remind pre-commit hooks setup. |
Tcc0403
approved these changes
Mar 18, 2026
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence