Merged
Conversation
ambry-router/src/main/java/com/github/ambry/router/PutOperation.java
Outdated
Show resolved
Hide resolved
ambry-router/src/main/java/com/github/ambry/router/PutOperation.java
Outdated
Show resolved
Hide resolved
| * after the associated chunk is complete, the buffer is not reused even though the PutChunk is reused. | ||
| */ | ||
| @Test | ||
| public void testRetry() throws Exception { |
Collaborator
There was a problem hiding this comment.
could you please change the function to something like testRetryOnSimpleOperationTrackerConstructorFailure?
ambry-router/src/test/java/com/github/ambry/router/PutOperationTest.java
Show resolved
Hide resolved
ambry-router/src/test/java/com/github/ambry/router/PutOperationTest.java
Outdated
Show resolved
Hide resolved
ambry-router/src/test/java/com/github/ambry/router/PutOperationTest.java
Outdated
Show resolved
Hide resolved
| // Mock the behavior of getRandomWritablePartition to return different values on each call | ||
| doAnswer(invocation -> { | ||
| int callNum = callCount.getAndIncrement(); // Increment call count and get the current value | ||
| if (callNum == 0) { |
Collaborator
There was a problem hiding this comment.
This if statement should be
if (callCount.getAndIncrement() == 0) {
return mockPartitionIdFail;
} else {
return mockPartitionIdPass;
}
justinlin-linkedin
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
added retry to find partition to avoid exceptions
Testing Done
New UT and ensure existing UT passes