Conversation
DevenAhluwalia
requested changes
Mar 18, 2025
...y-file-transfer/src/main/java/com/github/ambry/filetransfer/FileBasedReplicationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Show resolved
Hide resolved
...ion/src/test/java/com/github/ambry/replica/prioritization/FSFCPrioritizationManagerTest.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
added 4 commits
March 19, 2025 00:35
…py-control-plane-2
added 2 commits
March 24, 2025 10:48
aga9900
changed the title
ambry-cloud/src/main/java/com/github/ambry/cloud/CloudStorageManager.java
Outdated
Show resolved
Hide resolved
...le-transfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationManager.java
Outdated
Show resolved
Hide resolved
...le-transfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationManager.java
Show resolved
Hide resolved
...le-transfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationManager.java
Show resolved
Hide resolved
...le-transfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationManager.java
Show resolved
Hide resolved
...nsfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationSchedulerImpl.java
Show resolved
Hide resolved
...nsfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationSchedulerImpl.java
Show resolved
Hide resolved
...nsfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationSchedulerImpl.java
Outdated
Show resolved
Hide resolved
...nsfer/src/main/java/com/github/ambry/filetransfer/FileCopyBasedReplicationSchedulerImpl.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/github/ambry/replica/prioritization/FCFSPrioritizationManager.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 27, 2025 10:44
| if (latch == null) { | ||
| logger.info("Skipping file copy for existing partition {}", partitionName); | ||
| } else { | ||
| logger.info("Waiting for new partition {} to complete file copy", partitionName); |
Contributor
There was a problem hiding this comment.
Do you want to add metrics for replicas waiting for FileCopy completion
Contributor
Author
There was a problem hiding this comment.
We will create a separate sensor and add all metrics there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interface for Prioritisation Manager.
Implementation of FCFS Priotisation Manager
Implementation for:
FileCopyBasedReplicaManager
FC Scheduler
FCFS PrioritizationManager
Replica Sync Up manager
Testing Done
Test Cases