Use dynamic copyright year in helix-front footer + fix broken CI#178
Merged
Conversation
Replace hardcoded 2022 with the current year from the user's browser so it stays up to date automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Can you look into why the CI checks are failing here? |
Node 14 is EOL and incompatible with @angular/common engine check. Also bumps actions/checkout and actions/setup-node from v3 to v4 to address the Node.js 20 deprecation warning in GitHub Actions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The project engines field restricts to Node 14, but yarn's preflight engine check incorrectly flags @angular/common@19.2.16 (the lockfile correctly pins to 13.3.9). Using --ignore-engines bypasses the false positive while keeping the actual build on a modern Node LTS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Node 18 breaks the canvas native module (missing pixman-1 pre-built binary). The project targets Node 14. Keep --ignore-engines to bypass the false @angular/common@19.2.16 engine check from yarn preflight. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The .npmrc registry (npmjs.com) differs from lockfile URLs (yarnpkg.com), causing yarn to re-resolve @angular/common to 19.2.16 instead of 13.3.9. --frozen-lockfile forces strict lockfile adherence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Yarn checks engine constraints before lockfile enforcement, so @angular/common@19.2.16 engine check fires before the lockfile can pin it to 13.3.9. Need both flags together. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The .npmrc specifies registry.npmjs.com while the lockfile resolved URLs point to registry.yarnpkg.com. This mismatch may cause yarn to re-resolve packages. Override with .yarnrc to force consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yarn 1.22.22 (CI default) resolves @angular/common to 19.2.16 despite the lockfile pinning to 13.3.9. yarn 1.22.10 (local) correctly resolves to 13.3.9. Pin CI to 1.22.10 to match working local behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The .npmrc registry (npmjs.com) causes yarn to re-resolve @angular/common to 19.2.16 instead of using the lockfile's 13.3.9. Locally the global yarn config overrides .npmrc, but CI has no global config. Fix by overwriting .npmrc with the registry matching lockfile URLs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove all workarounds and cache to isolate the problem. No cache, no frozen-lockfile, no registry override, no yarn pin. Just node 14 + yarn + --ignore-engines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Root cause: .npmrc pointed to registry.npmjs.com while yarn.lock resolved URLs use registry.yarnpkg.com. On Linux CI runners, this mismatch causes yarn to re-resolve @angular/common to 19.2.16 instead of the locked 13.3.9. Fixed by aligning .npmrc registry with the lockfile. Also bumped actions to v4 and added --ignore-engines to handle engine check false positives during fetching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yarn 1.22.22 on Ubuntu Linux resolves @angular/common to 19.2.16 despite lockfile, resolutions, and package.json all pinning to 13.3.9. This is a confirmed yarn bug that does not reproduce on macOS. Switching to npm install as a workaround. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dependabot PR apache#3083 bumped @angular/common from 13.3.9 to 19.2.16 without bumping @angular/core (still 13.3.9). Angular requires all @angular/* packages at the same version, so this broke the build. Changes: - Revert @angular/common to 13.3.9 in package.json and yarn.lock - Update CI workflow: actions v3->v4, add --frozen-lockfile Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dependabot PR apache#3083 bumped only @angular/common to 19.2.16 while all other @angular/* packages remain at 13.3.9. Angular requires all packages at the same version. Reverting to 13.3.9. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kabragaurav
changed the title
thestreak101
approved these changes
May 18, 2026
kabragaurav
pushed a commit
that referenced
this pull request
May 18, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kabragaurav
pushed a commit
that referenced
this pull request
May 18, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2022in the footer with{{ currentYear }}bound tonew Date().getFullYear()@angular/commonto 19.2.16 while all other@angular/*packages remain at 13.3.9. Angular requires all packages at the same version. Reverted@angular/commonback to 13.3.9 inpackage.jsonandyarn.lockactions/checkoutandactions/setup-nodefrom v3 to v4, added--frozen-lockfileto prevent future lockfile driftTesting Done