Partially shade iceberg-hive-metastore for HiveSchemaUtils usage #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamurko
approved these changes
Dec 12, 2025
Collaborator
teamurko
left a comment
teamurko
left a comment
There was a problem hiding this comment.
if possible, we can have current module unchanges and produce shaded version in addition?
teamurko
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are some usages of
HiveSchemaUtilsin the hive to iceberg migration, however theiceberg-hive-metastoremodule did not properly include the dependencies in RuntimeClasspath. This PR adds shading to the module and relocate hive related classes so it won't break the existing classes in the hive environment. Also sinceHiveSchemaUtilsis the only use case, we should only partially shade the jars so that we don't need to deal with massive exclusions and relocations.Tests
Integration tests
Tested the snapshot shaded jar in
li-openhouse-java-runtimewithHiveSchemaUtilstests and worked.Shadow jar check
The necessary classes exist and being relocated. The jar size is 18mb compared to 36mb for full shading.