Introduce branching and support for spark.wap.branch#406
Merged
Conversation
teamurko
requested changes
Dec 3, 2025
sumedhsakdeo
previously approved these changes
Dec 3, 2025
0f048a6 to
40d056b
Compare
teamurko
previously approved these changes
Dec 3, 2025
Collaborator
teamurko
left a comment
There was a problem hiding this comment.
Left minor comments in tests. The core logic looks good.
teamurko
previously approved these changes
Dec 3, 2025
sumedhsakdeo
previously approved these changes
Dec 4, 2025
sumedhsakdeo
approved these changes
Dec 4, 2025
teamurko
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement Iceberg table branching functionality in OpenHouse internal catalog with comprehensive testing infrastructure.
Strategically, we trust that only a valid client performs the operation. This is safe because in fact O.S. model has the client write metadata.json and send the pointer to the catalog server. So, GlueCatalog (e.g. gluetableoperations.java), DynamoDbCatalog, jdbctableoperations.java do client-only metadata operations (no server-side validation exists). The client behavior is also covered extensively by Iceberg compatibility tests applied to openhouse.
When we trust the client, we simply serialize the client request and later deserialize it. Since TableMetadata fields lack public access and only some are exposed via the builder, we start from the base metadata, take the serialized client request, and apply it to base by comparing with request and: truncating snapshot IDs from base, adding new IDs from the request, and moving the current pointer according to the request.
how to test
oh suite tests - this branch
compatibility tests - includes this branch + new shim files, and also requires this iceberg
https://github.com/cbb330/openhouse/tree/working-wap-compatibility
https://github.com/cbb330/iceberg/tree/test-harness
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.