Honor previous metadata maximum versions configuration defined by the user.#429
Merged
shanthoosh merged 1 commit intolinkedin:mainfrom Jan 8, 2026
Conversation
...main/java/com/linkedin/openhouse/tables/repository/impl/OpenHouseInternalRepositoryImpl.java
Show resolved
Hide resolved
a977e46 to
5f42e27
Compare
abhisheknath2011
previously approved these changes
Jan 8, 2026
… defined by the user.
5f42e27 to
46f3933
Compare
abhisheknath2011
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The table-configuration:
write.metadata.previous-versions-maxin Apache Iceberg sets the maximum number of old metadata files (snapshots) to keep before they are potentially deleted after a new commit. In openhouse catalog, it is always hardcoded to be 168 regardless of the value defined for the configuration in the table-properties by the user. For streaming applications, which commits frequently (every 5 mins) to iceberg, it is essential to allow users to override this configuration so that they can control the time-travel queries for long duration and rollback to any previous snapshots if needed.To support the above, this patch sets the configuration:
write.metadata.previous-versions-maxto default value of 168 only if it is not defined by the user in their table properties.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Added unit tests for changes introduced.
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.