Improved e2e test coverage for PR#453#525
Merged
dushyantk1509 merged 1 commit intolinkedin:mainfrom Apr 3, 2026
Merged
Conversation
Collaborator
Author
|
@mkuchenbecker Could you pls review this? |
maluchari
reviewed
Apr 1, 2026
The existing test only covered delete scenarios after linkedin#453. This update adds update regression coverage and combines all assertions into a single test that verifies: - Update on replica is denied without SYSTEM_ADMIN - Delete on replica is denied without DELETE_TABLE - Delete on replica succeeds with DELETE_TABLE (even without SYSTEM_ADMIN) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dushyantk1509
force-pushed
the
dushyantk1509/allow-replica-table-drop
branch
from
eb35f1b to
5b51776
Compare
dushyantk1509
changed the title
Collaborator
Author
|
@maluchari I've merged this PR - https://github.com/linkedin/openhouse/pull/453/changes and updated this PR to include tests to improve the test coverage. |
maluchari
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.