Integrate batched orphan files deletion with the existing schedule workflow#604
Draft
abhisheknath2011 wants to merge 4 commits into
Draft
Integrate batched orphan files deletion with the existing schedule workflow#604abhisheknath2011 wants to merge 4 commits into
abhisheknath2011 wants to merge 4 commits into
Conversation
| * <p>Construct with the {@link Config} builder to override the default timeouts. | ||
| */ | ||
| @Slf4j | ||
| public class OptimizerServiceClient implements AutoCloseable { |
| .build(); | ||
|
|
||
| Map<String, List<TableMetadata>> byDb = | ||
| eligible.stream().collect(Collectors.groupingBy(TableMetadata::getDbName)); |
Member
Author
There was a problem hiding this comment.
Group the tables by DBs.
| */ | ||
| @Slf4j | ||
| @Getter | ||
| public class BatchedTableOrphanFilesDeletionTask extends OperationTask<TableMetadataBatch> { |
Member
Author
There was a problem hiding this comment.
Task implementation for batch job submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the new
BatchedOrphanFilesDeletionSparkApp(from #599) into the existingJobsSchedulerflow so operators can amortize Spark startup over many tables today, without waiting for the optimizer-service stack to land. Batched OFD is opt-in via a new JobType — the existing single-tableORPHAN_FILES_DELETIONpath is untouched.How it works
Key design choices
headroom for the spark-submit envelope. Enforced at both the Spark app boundary (buildEntries) and the scheduler boundary (fail-fast on --batchMaxItems > 200).
Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.
Changes
Service contract (services/jobs)
Scheduler (apps/spark)
buildOperationTaskListInParallel (bulk-enqueue path because batching needs all metadata in hand first).
Spark app changes from #599
Rollout plan
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.