[build] Enforce module-level code coverage verfication#157
Merged
adamxchen merged 12 commits intolinkedin:mainfrom Jan 10, 2023
Merged
[build] Enforce module-level code coverage verfication#157adamxchen merged 12 commits intolinkedin:mainfrom
adamxchen merged 12 commits intolinkedin:mainfrom
Conversation
FelixGV
reviewed
Jan 6, 2023
# Conflicts: # internal/venice-test-common/build.gradle
anaberezhnov
reviewed
Jan 9, 2023
Contributor
|
Are you planning to skip generated and test classes from the check? |
Contributor
Author
For the record, I think this commit lists these classes. |
anaberezhnov
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to ensure enough unit tests will be written for each new PR and gradually improve code coverage among modules.
Start with a new CI step which verifies each module has met enough line coverages. The threshold is defined per module and we can continue tweaking it as we go.
Note that this PR doesn't introduce new code coverage check, only module-level code coverage check. The former will be done in a later PR.
Testing
./gradlew jacocoTestCoverageVerificationand the new CI step.WcTest/7390
For a build that meets the coverage requirements:
https://github.com/linkedin/venice/actions/runs/3852662122/jobs/6564983018
For a build that doesn't meet the coverage requirements:
https://github.com/linkedin/venice/actions/runs/3852887609/jobs/6565384906