[all][build] Fix spotbug bugs and enforce low report level#170
Merged
adamxchen merged 9 commits intolinkedin:mainfrom Jan 20, 2023
Merged
[all][build] Fix spotbug bugs and enforce low report level#170adamxchen merged 9 commits intolinkedin:mainfrom
adamxchen merged 9 commits intolinkedin:mainfrom
Conversation
FelixGV
reviewed
Jan 12, 2023
# Conflicts: # internal/venice-test-common/build.gradle
lluwm
reviewed
Jan 19, 2023
lluwm
previously approved these changes
Jan 20, 2023
Contributor
lluwm
left a comment
There was a problem hiding this comment.
Adam, thank you for fixing all spotbug warnings! Nice work and it looks good to me.
majisourav99
approved these changes
Jan 20, 2023
Contributor
majisourav99
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the effort Adam!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our Github Action enables the SpotBugs check but ignores the failure.
The PR changes the report level fromReport level stays at low as I've fixed most of bugs.lowtohigh, aslowlevel reports too many bugs and cannot be fixed at a short term.Apologies for the huge PR, however given most of changes are quite trivial, mostly related to missing final/static keyword, dead codes or minor details, I think it's better to include them all in this PR so we don't have to bug people to review multiple PRs.
What to review
For the review, please pay attention on these items:
Testing
WcTest jdk11 7460/7462/7464/7502
WcTest jdk8 1145/46/47