[vpj] Explicitly detect Vson file and not suppress IOException #1745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
There is no official utility to detect if a file is a
SequenceFile. We rely onSequenceFile.Readerto throw anIOExceptionand then we catch thisIOExceptionand track allIOExceptionerrors as not being aSequenceFile. However, this approach masks trueIOExceptionand eventually, VPJ ends up with aNullPointerExceptionthrough some sequence of events.Solution
This PR adds an explicit function to check for a
SequenceFileusing the file headers.Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?