Skip to content

Conversation

@FelixGV
Copy link
Contributor

@FelixGV FelixGV commented Apr 30, 2025

In a system store creation code path, made use of default partition count rather than failing, in some scenario.

Miscellaneous:

  • Reduced log message size in HelixSchemaAccessor, by printing only schema IDs and not full schema literals.

  • Fixed string interpolation in VeniceParentHelixAdmin::initiateDataRecovery.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Reduced log volume, actually.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

FelixGV added 2 commits April 30, 2025 12:09
In a system store creation code path, made use of default partition count
rather than failing, in some scenario.

Miscellaneous:

- Reduced log message size in HelixSchemaAccessor, by printing only schema
  IDs and not full schema literals.

- Fixed string interpolation in VeniceParentHelixAdmin::initiateDataRecovery.
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @FelixGV!

@FelixGV FelixGV enabled auto-merge (squash) May 1, 2025 15:29
@FelixGV FelixGV merged commit 9b254e2 into linkedin:main May 1, 2025
58 checks passed
WhitneyDeng pushed a commit to WhitneyDeng/venice that referenced this pull request May 16, 2025
In a system store creation code path, made use of default partition count
rather than failing, in some scenario.

Miscellaneous:

- Reduced log message size in HelixSchemaAccessor, by printing only schema
  IDs and not full schema literals.

- Fixed string interpolation in VeniceParentHelixAdmin::initiateDataRecovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants