[build] Save build artifacts on GH-CI runs#263
Merged
sushantmane merged 8 commits intolinkedin:mainfrom Mar 7, 2023
Merged
Conversation
FelixGV
reviewed
Mar 6, 2023
Contributor
FelixGV
left a comment
FelixGV
left a comment
There was a problem hiding this comment.
Thanks! Were you able to test that the uploading works in your own branch?
I left a few minor questions. Looking forward to seeing this merged!!
sushantmane
force-pushed
the
ghci-save-logs-for-failed-integration-tests
branch
2 times, most recently
from
fc00bc8 to
e2943c2
Compare
sushantmane
force-pushed
the
ghci-save-logs-for-failed-integration-tests
branch
2 times, most recently
from
df102ad to
2ed0b64
Compare
FelixGV
previously approved these changes
Mar 7, 2023
Contributor
FelixGV
left a comment
FelixGV
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot Sushant!!
sushantmane
force-pushed
the
ghci-save-logs-for-failed-integration-tests
branch
from
2ed0b64 to
78ffe26
Compare
sushantmane
changed the title
nisargthakkar
approved these changes
Mar 7, 2023
Contributor
nisargthakkar
left a comment
nisargthakkar
left a comment
There was a problem hiding this comment.
LGTM. Let's reassess about the disk usage later if we face issues
Contributor
Author
|
Thanks a lot, @nisargthakkar and @FelixGV! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save logs for failed integration tests on gh-ci
Resolves #178
How was this PR tested?
Does this PR introduce any user-facing changes?