Remove clone in opencensus exporter to ensure task is notified #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
approved these changes
Jan 8, 2020
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jan 15, 2020
This release fixes an issue that could cause the OpenCensus exporter to stall. This release does NOT include the experimental changes from v2.83.0-experimental. --- * http: Use the endpoint type to inform URI normalization (linkerd/linkerd2-proxy#404) * Remove clone in opencensus exporter to ensure task is notified (linkerd/linkerd2-proxy#405)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jan 15, 2020
This release fixes an issue that could cause the OpenCensus exporter to stall. This release does NOT include the experimental changes from v2.83.0-experimental. --- * http: Use the endpoint type to inform URI normalization (linkerd/linkerd2-proxy#404) * Remove clone in opencensus exporter to ensure task is notified (linkerd/linkerd2-proxy#405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the opencensus span exporter, we call
poll_readyon the span send channel sender to determine if there is capacity in this channel to send spans. However, the channel sender that wepoll_readyon is a clone of the original and the clone is dropped shortly after the call topoll_ready. This can cause our interest registration to be dropped and the task may not be notified when capacity becomes available.The clone is unnecessarily and we can remove it.
Signed-off-by: Alex Leong alex@buoyant.io