fix(policy-k8s): use correct resource labels in outbound indexer logs#15314
Merged
Conversation
The EgressNetwork indexer warning messages used service=name as the structured log field, which is misleading when the resource being indexed is an EgressNetwork. Change to egress_network=name in the four warning lines (accrual config, timeouts, http retry, grpc retry) so operators see the correct resource type when investigating parse errors. Signed-off-by: Alejandro Martinez Ruiz <amr@buoyant.io>
The Service and EgressNetwork indexer debug!() calls used bare name and ns fields, while their sibling warn!() calls used explicit service=name and egress_network=name labels. Use labeled fields in the debug lines as well so structured log output is consistent within each indexer implementation. Signed-off-by: Alejandro Martinez Ruiz <amr@buoyant.io>
cratelyn
approved these changes
May 26, 2026
adleong
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outbound policy index's
IndexNamespacedResource<EgressNetwork>implementation used
service=nameas the structured log field in itsfour
warn!()calls (accrual config, timeouts, HTTP retry, gRPCretry). This was probably a copy-paste artifact from the adjacent
IndexNamespacedResource<Service>implementation, making log outputmisleading when an EgressNetwork resource fails annotation parsing.
Additionally, both indexers used bare
name, nsfields in theirdebug!()calls while their siblingwarn!()calls used explicitlabeled fields (
service=name, namespace=nsandegress_network=name, namespace=ns). This inconsistency meant thesame resource appeared under different field names depending on log
level.
This replaces
service=namewithegress_network=namein the fourEgressNetwork
warn!()calls so operators see the correct resourcetype when investigating parse errors, and adds explicit labels to
both indexers'
debug!()calls so field names are consistent acrosslog levels within each implementation.
Signed-off-by: Alejandro Martinez Ruiz <amr@buoyant.io>