Unify issuance lifetime name#3887
Merged
Merged
Conversation
grampelberg
reviewed
Jan 6, 2020
Contributor
grampelberg
left a comment
grampelberg
left a comment
There was a problem hiding this comment.
LGTM. Are there any upgrade concerns for this change?
Member
Author
|
@grampelberg not that I can think of. @ihcsim can you think of some case where that would break upgrade ? |
6 tasks
ihcsim
approved these changes
Jan 6, 2020
Contributor
ihcsim
left a comment
ihcsim
left a comment
There was a problem hiding this comment.
LGTM.
Re upgrade, #3823 is a breaking change for pre-2.7 Helm users anyway. The change in this PR shouldn't be a problem. I have updated linkerd/website#607 to include this in the upgrade notes.
adleong
approved these changes
Jan 6, 2020
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
force-pushed
the
zd/unify-issuance-lifetime-name
branch
from
a0311c8 to
aa88513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to wrong snake casing, lifetime setting lifetime issuance was not reflected when installing through helm. I think it is best to unify the spelling.
Signed-off-by: Zahari Dichev zaharidichev@gmail.com