Skip to content

Add tap subcommand section with skipped ports note to viz CLI docs#2106

Closed
Mike-4-prog wants to merge 2 commits intolinkerd:mainfrom
Mike-4-prog:docs-viz-tap-section
Closed

Add tap subcommand section with skipped ports note to viz CLI docs#2106
Mike-4-prog wants to merge 2 commits intolinkerd:mainfrom
Mike-4-prog:docs-viz-tap-section

Conversation

@Mike-4-prog
Copy link
Copy Markdown

Problem

The linkerd viz tap subcommand is not explicitly documented in the CLI reference, and behavior related to skipped ports is not clear to users.

Solution

Add a tap subcommand section under viz.md, including:

  • CLI description, examples, and flags via shortcodes
  • A note explaining that traffic on skipped ports cannot be tapped

Result

Improves discoverability and clarity for users troubleshooting linkerd viz tap.

This follows up on feedback from #2105.

Signed-off-by: MIKE-4-prog <uzukwuekene.michael@gmail.com>
@Mike-4-prog
Copy link
Copy Markdown
Author

Hi @kflynn, @cratelyn, @travisbeckham

This PR (#2106) follows up on #2105, adding the tap subcommand section under viz.md with a note explaining that traffic on skipped ports cannot be tapped.

The goal is to improve discoverability and clarity for users troubleshooting linkerd viz tap. All content has been added via shortcodes, including description, examples, and flags.

Looking forward to your review and feedback!

Thanks,
Mike

Signed-off-by: MIKE-4-prog <uzukwuekene.michael@gmail.com>
@cratelyn
Copy link
Copy Markdown
Member

hey @Mike-4-prog, we were in the middle of reviewing this work in #2105. i'd prefer if we continued that work there, instead of opening a new PR here. it makes it harder to follow review comments, and introduces additional noise to our inboxes.

@cratelyn cratelyn closed this Mar 30, 2026
@Mike-4-prog
Copy link
Copy Markdown
Author

hey @Mike-4-prog, we were in the middle of reviewing this work in #2105. i'd prefer if we continued that work there, instead of opening a new PR here. it makes it harder to follow review comments, and introduces additional noise to our inboxes.

@cratelyn yes, but I noticed the previous PR #2105 was closed without merging. What's the way forward on this now

@Mike-4-prog Mike-4-prog deleted the docs-viz-tap-section branch March 30, 2026 15:20
@Mike-4-prog
Copy link
Copy Markdown
Author

@cratelyn Please disregard this branch and PR. I see it has been closed already and I have gone ahead to delete the branch too. My apologies for the confusion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants