Add tap subcommand section with skipped ports note to viz CLI docs#2106
Add tap subcommand section with skipped ports note to viz CLI docs#2106Mike-4-prog wants to merge 2 commits intolinkerd:mainfrom
Conversation
Signed-off-by: MIKE-4-prog <uzukwuekene.michael@gmail.com>
|
Hi @kflynn, @cratelyn, @travisbeckham This PR (#2106) follows up on #2105, adding the tap subcommand section under viz.md with a note explaining that traffic on skipped ports cannot be tapped. The goal is to improve discoverability and clarity for users troubleshooting linkerd viz tap. All content has been added via shortcodes, including description, examples, and flags. Looking forward to your review and feedback! Thanks, |
Signed-off-by: MIKE-4-prog <uzukwuekene.michael@gmail.com>
|
hey @Mike-4-prog, we were in the middle of reviewing this work in #2105. i'd prefer if we continued that work there, instead of opening a new PR here. it makes it harder to follow review comments, and introduces additional noise to our inboxes. |
@cratelyn yes, but I noticed the previous PR #2105 was closed without merging. What's the way forward on this now |
|
@cratelyn Please disregard this branch and PR. I see it has been closed already and I have gone ahead to delete the branch too. My apologies for the confusion here. |
Problem
The
linkerd viz tapsubcommand is not explicitly documented in the CLI reference, and behavior related to skipped ports is not clear to users.Solution
Add a
tapsubcommand section underviz.md, including:Result
Improves discoverability and clarity for users troubleshooting
linkerd viz tap.This follows up on feedback from #2105.