Move linkml to runtime dependencies to prevent version skew#192
Merged
amc-corey-cox merged 2 commits intomainfrom Apr 7, 2026
Merged
Move linkml to runtime dependencies to prevent version skew#192amc-corey-cox merged 2 commits intomainfrom
amc-corey-cox merged 2 commits intomainfrom
Conversation
linkml is imported at runtime (data_loaders.py uses linkml.validator.loaders) but was only in dev dependencies. Downstream users got linkml-runtime>=1.10.0 without a matching linkml constraint, allowing uv to resolve an older linkml that's incompatible with runtime 1.10.0 (Format.JSON rename). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures linkml is installed for downstream users by promoting it to a runtime dependency, preventing version skew between linkml and linkml-runtime that can cause runtime import errors (notably around JSON format handling).
Changes:
- Add
linkml>=1.10.0to runtime dependencies inpyproject.toml. - Regenerate
uv.lockso the publishedrequires-distand editable package dependency set includeslinkml.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Adds linkml>=1.10.0 to runtime dependencies so end users get linkml installed. |
uv.lock |
Updates the locked metadata/dependency lists to reflect linkml as a runtime requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkml>=1.10.0from dev dependencies to runtime dependenciesdata_loaders.pyimportslinkml.validator.loadersat runtime, so downstream users need the constraintFormat.JSONimport errorsTest plan
🤖 Generated with Claude Code