yumlgen: use POST and add ability to name output file#1293
yumlgen: use POST and add ability to name output file#1293cmungall merged 2 commits intolinkml:mainfrom
Conversation
c9ecc81 to
d256e7e
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 80.33% 80.35% +0.02%
==========================================
Files 77 77
Lines 8995 9001 +6
Branches 2212 2212
==========================================
+ Hits 7226 7233 +7
+ Misses 1347 1346 -1
Partials 422 422
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d256e7e to
445b68c
Compare
| rendering will be saved in file | ||
| --diagram-name TEXT Name of the diagram in the output directory | ||
| (without suffix!) | ||
| -f, --format [yuml|png|pdf|jpg|json|svg] |
There was a problem hiding this comment.
When I ran the tests, there were actually more changes to the currently checked in files but they were unrelated and I left them out.
Not sure why the tests do not complain about these discrepancies, either the tests are run twice or these changes do not register :-(
There was a problem hiding this comment.
@hsolbrig is working on refactoring the test framework...
cmungall
left a comment
There was a problem hiding this comment.
Many thanks! We are focusing efforts on mermaid but this still doesn't support everything supported by yumlgen, so this is most welcome
|
Mermaid would definitely be nice, we also would want that: our goal in the end is to import the whole generated doc into a azure wiki (based on markdown files in a git, so simply comitting would work) |
We needed these two changes to
a) generate bigger diagrams
b) have more control over how the filenames end up