Skip to content

yumlgen: use POST and add ability to name output file#1293

Merged
cmungall merged 2 commits intolinkml:mainfrom
jankatins:more_robust_yumlgen
Feb 21, 2023
Merged

yumlgen: use POST and add ability to name output file#1293
cmungall merged 2 commits intolinkml:mainfrom
jankatins:more_robust_yumlgen

Conversation

@jankatins
Copy link
Contributor

@jankatins jankatins commented Feb 17, 2023

We needed these two changes to
a) generate bigger diagrams
b) have more control over how the filenames end up

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #1293 (c9ecc81) into main (4ceeba1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c9ecc81 differs from pull request most recent head d256e7e. Consider uploading reports for the commit d256e7e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   80.33%   80.35%   +0.02%     
==========================================
  Files          77       77              
  Lines        8995     9001       +6     
  Branches     2212     2212              
==========================================
+ Hits         7226     7233       +7     
+ Misses       1347     1346       -1     
  Partials      422      422              
Impacted Files Coverage Δ
linkml/generators/yumlgen.py 94.73% <100.00%> (+1.58%) ⬆️
linkml/utils/schemaloader.py 78.92% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rendering will be saved in file
--diagram-name TEXT Name of the diagram in the output directory
(without suffix!)
-f, --format [yuml|png|pdf|jpg|json|svg]
Copy link
Contributor Author

@jankatins jankatins Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the tests, there were actually more changes to the currently checked in files but they were unrelated and I left them out.

Not sure why the tests do not complain about these discrepancies, either the tests are run twice or these changes do not register :-(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsolbrig is working on refactoring the test framework...

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! We are focusing efforts on mermaid but this still doesn't support everything supported by yumlgen, so this is most welcome

@cmungall cmungall merged commit 950a645 into linkml:main Feb 21, 2023
@jankatins
Copy link
Contributor Author

Mermaid would definitely be nice, we also would want that: our goal in the end is to import the whole generated doc into a azure wiki (based on markdown files in a git, so simply comitting would work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants