Skip to content

fix mergeimports issue in docgen#1309

Merged
cmungall merged 4 commits intomainfrom
docgen-merge-imports
Feb 25, 2023
Merged

fix mergeimports issue in docgen#1309
cmungall merged 4 commits intomainfrom
docgen-merge-imports

Conversation

@sujaypatil96
Copy link
Member

Merge PR #1308 first

This PR seeks to solve the problem that @noelmcloughlin was facing in PR #1283

@sujaypatil96
Copy link
Member Author

@noelmcloughlin: if you agree with the changes in this PR, then we can merge this in and close out PR #1283

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #1309 (376878d) into main (4ceeba1) will decrease coverage by 0.06%.
The diff coverage is 76.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
- Coverage   80.33%   80.27%   -0.06%     
==========================================
  Files          77       77              
  Lines        8995     9065      +70     
  Branches     2212     2235      +23     
==========================================
+ Hits         7226     7277      +51     
- Misses       1347     1358      +11     
- Partials      422      430       +8     
Impacted Files Coverage Δ
linkml/generators/typescriptgen.py 90.12% <ø> (-0.13%) ⬇️
linkml/utils/ifabsent_functions.py 81.81% <ø> (+0.42%) ⬆️
linkml/generators/common/type_designators.py 65.21% <69.23%> (-16.61%) ⬇️
linkml/generators/pydanticgen.py 86.19% <73.68%> (+0.92%) ⬆️
linkml/generators/yumlgen.py 93.42% <87.50%> (+0.27%) ⬆️
linkml/generators/docgen.py 84.50% <100.00%> (-0.88%) ⬇️
linkml/generators/javagen.py 81.15% <100.00%> (+0.27%) ⬆️
linkml/utils/schemaloader.py 78.55% <0.00%> (-0.56%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cmungall cmungall merged commit 56c51f2 into main Feb 25, 2023
@noelmcloughlin
Copy link
Contributor

#1311

@sujaypatil96 sujaypatil96 deleted the docgen-merge-imports branch February 28, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docgen.py index.md not respect --no-mergeimports

4 participants