test: warn when OWL coherency checks are skipped#3312
Merged
matentzn merged 2 commits intolinkml:mainfrom Apr 8, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
+ Coverage 80.29% 83.93% +3.63%
==========================================
Files 151 151
Lines 17502 17502
Branches 3636 3636
==========================================
+ Hits 14054 14691 +637
+ Misses 2659 1975 -684
- Partials 789 836 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4aaf3f0 to
274a9ba
Compare
matentzn
approved these changes
Apr 8, 2026
Contributor
matentzn
left a comment
There was a problem hiding this comment.
This is great, thanks. I was thinking for a moment that stacklevel=3 might have been more appropriate for the warning, but in the end, I dont think it matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3301.
This stays on the narrow no-ROBOT honesty fix only:
PytestWarningwhen OWL coherency checks are skipped becauserobotis not onPATHROBOTpath asUNTESTEDin the compliance READMEFresh verification on this branch:
uv run --python 3.13 pytest tests/linkml/test_compliance/test_core_compliance.py -k 'min_max_values and owl' -q\n-uv run --python 3.13 pytest tests/linkml/test_compliance/test_boolean_slot_compliance.py -k 'any_of_streq_MV and owl' -q\n-PATH=/Volumes/Code_2TB/code/collaboration/.local-tools/linkml-robot/bin:$PATH uv run --python 3.13 pytest tests/linkml/test_compliance/test_core_compliance.py tests/linkml/test_compliance/test_boolean_slot_compliance.py -k 'owl and (min_max_values or any_of_streq_MV)' -q\n\nThe two issue-namedROBOTfailures still do not reproduce here on currentmain+ Python3.13+ROBOT 1.9.10, so this PR does not try to broaden into CIROBOTcoverage or a larger diagnosis change.