Skip to content

test: warn when OWL coherency checks are skipped#3312

Merged
matentzn merged 2 commits intolinkml:mainfrom
SproutSeeds:cody/issue-3301-owl-robot-warning
Apr 8, 2026
Merged

test: warn when OWL coherency checks are skipped#3312
matentzn merged 2 commits intolinkml:mainfrom
SproutSeeds:cody/issue-3301-owl-robot-warning

Conversation

@SproutSeeds
Copy link
Copy Markdown
Contributor

Part of #3301.

This stays on the narrow no-ROBOT honesty fix only:

  • emit a visible PytestWarning when OWL coherency checks are skipped because robot is not on PATH
  • document the no-ROBOT path as UNTESTED in the compliance README
  • keep current behavior otherwise unchanged

Fresh verification on this branch:

  • uv run --python 3.13 pytest tests/linkml/test_compliance/test_core_compliance.py -k 'min_max_values and owl' -q\n- uv run --python 3.13 pytest tests/linkml/test_compliance/test_boolean_slot_compliance.py -k 'any_of_streq_MV and owl' -q\n- PATH=/Volumes/Code_2TB/code/collaboration/.local-tools/linkml-robot/bin:$PATH uv run --python 3.13 pytest tests/linkml/test_compliance/test_core_compliance.py tests/linkml/test_compliance/test_boolean_slot_compliance.py -k 'owl and (min_max_values or any_of_streq_MV)' -q\n\nThe two issue-named ROBOT failures still do not reproduce here on current main + Python 3.13 + ROBOT 1.9.10, so this PR does not try to broaden into CI ROBOT coverage or a larger diagnosis change.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.93%. Comparing base (0a42f67) to head (f8fad26).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   80.29%   83.93%   +3.63%     
==========================================
  Files         151      151              
  Lines       17502    17502              
  Branches     3636     3636              
==========================================
+ Hits        14054    14691     +637     
+ Misses       2659     1975     -684     
- Partials      789      836      +47     
Flag Coverage Δ
linkml 80.29% <ø> (ø)
runtime 80.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SproutSeeds SproutSeeds force-pushed the cody/issue-3301-owl-robot-warning branch from 4aaf3f0 to 274a9ba Compare March 23, 2026 18:33
@matentzn matentzn self-requested a review March 26, 2026 17:57
Copy link
Copy Markdown
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks. I was thinking for a moment that stacklevel=3 might have been more appropriate for the warning, but in the end, I dont think it matters.

@matentzn matentzn enabled auto-merge April 8, 2026 13:19
@matentzn matentzn merged commit 46bf184 into linkml:main Apr 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants