fix(excel): class names longer than 31 chars#3527
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
+ Coverage 80.14% 83.59% +3.44%
==========================================
Files 157 157
Lines 18659 18677 +18
Branches 3931 3934 +3
==========================================
+ Hits 14955 15613 +658
+ Misses 2869 2183 -686
- Partials 835 881 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sujaypatil96
approved these changes
May 20, 2026
Member
sujaypatil96
left a comment
There was a problem hiding this comment.
Thanks for implementing a solution for the case when the class name length is >= 31 characters. The collision free/safe title name generation logic looks good and is an effective truncation strategy! definitely better than what we have already where the generation simply crashes/errors out, so love the improvement 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3526
Compute a deterministic, collision-free sheet title once per class and use it for both
create_sheetand the subsequent lookup.Keep a
cls_name -> sheet_titlemap.How was this tested?
Areas of uncertainty
Checklist
AI Assistance
LLM assisted unit tests