Skip to content

fix(excel): class names longer than 31 chars#3527

Merged
sujaypatil96 merged 2 commits into
linkml:mainfrom
noelmcloughlin:excel2
May 21, 2026
Merged

fix(excel): class names longer than 31 chars#3527
sujaypatil96 merged 2 commits into
linkml:mainfrom
noelmcloughlin:excel2

Conversation

@noelmcloughlin
Copy link
Copy Markdown
Contributor

Summary

Fixes #3526

Compute a deterministic, collision-free sheet title once per class and use it for both create_sheet and the subsequent lookup.

Keep acls_name -> sheet_title map.

How was this tested?

Areas of uncertainty

Checklist

  • My code follows the contributor guidelines
  • I have added tests that prove my fix/feature works
  • Existing tests pass locally with my changes

AI Assistance

LLM assisted unit tests

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.59%. Comparing base (877584d) to head (1cfb7c3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
+ Coverage   80.14%   83.59%   +3.44%     
==========================================
  Files         157      157              
  Lines       18659    18677      +18     
  Branches     3931     3934       +3     
==========================================
+ Hits        14955    15613     +658     
+ Misses       2869     2183     -686     
- Partials      835      881      +46     
Flag Coverage Δ
linkml 80.17% <100.00%> (+0.03%) ⬆️
runtime 80.17% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@sujaypatil96 sujaypatil96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a solution for the case when the class name length is >= 31 characters. The collision free/safe title name generation logic looks good and is an effective truncation strategy! definitely better than what we have already where the generation simply crashes/errors out, so love the improvement 🚀

@sujaypatil96 sujaypatil96 enabled auto-merge May 20, 2026 23:57
@sujaypatil96 sujaypatil96 merged commit b40f736 into linkml:main May 21, 2026
19 checks passed
@noelmcloughlin noelmcloughlin deleted the excel2 branch May 21, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

excelgen crash on class names longer than 31 chars

3 participants