add NANDO: to curated prefix yaml to fix identifiers.org/NANDO/123 expansions#79
Merged
kevinschaper merged 1 commit intomainfrom Oct 31, 2025
Merged
add NANDO: to curated prefix yaml to fix identifiers.org/NANDO/123 expansions#79kevinschaper merged 1 commit intomainfrom
kevinschaper merged 1 commit intomainfrom
Conversation
amc-corey-cox
approved these changes
Oct 29, 2025
Contributor
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
This looks good to me. Do you think it's worthwhile to write some kind of test to ensure this doesn't revert? I'll leave that up to you.
Contributor
Author
|
I think this doesn’t change the mechanism of preference for the curated yaml, so it doesn’t necessarily call for new tests, but it would be nice to have some tests for the expectations we have…just not in this quick fix PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to address monarch-initiative/monarch-app#1221