Skip to content

fix: methods protected vs private #5760#9

Merged
joostfaassen merged 1 commit intolinkorb:masterfrom
prajapati-kaushik:5760-methods-protected-vs-private
Feb 21, 2022
Merged

fix: methods protected vs private #5760#9
joostfaassen merged 1 commit intolinkorb:masterfrom
prajapati-kaushik:5760-methods-protected-vs-private

Conversation

@prajapati-kaushik
Copy link
Copy Markdown
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If this relates to a card, please include a link to the card here.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added/updated necessary documentation in the README.md or doc/ directories (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@joostfaassen joostfaassen merged commit aa3bbcb into linkorb:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants