Fix broken storage key encryption; S3 adapter fixes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage key is now the hashed (and authenticated) original storage key so that lookups succeed. The storage key was encrypted npn-deterministicaly in the previous implementation which made lookups fail. Storage keys are guaranteed not to have been tampered with (say, an attacker replaces a stored value with another, authentic value, but that is not related to the original storage key).
The default was "public-read" :o Now it is "private" and can be configured at build time by supplying a config with key "canned_acl_for_objects".
joostfaassen
approved these changes
Jun 8, 2019
Member
joostfaassen
left a comment
joostfaassen
left a comment
There was a problem hiding this comment.
@jah thanks! Happy to retrieve objects again :) Should I tag this as v4.0.0 ?
| "symfony/console": "^4", | ||
| "aws/aws-sdk-php": "^3", | ||
| "friendsofphp/php-cs-fixer": "^2.15", | ||
| "phpstan/phpstan": "^0.11.8", |
Collaborator
Author
Heh heh. Yes please v4.0.0 is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0c8f61f Changes
to
so that we can actually retrive our objects ;) and to provide assurance that:-
d9cec37 fixes the S3 adapter so that it works with a modern aws-sdk-php
4e51144 changes the default S3 "canned ACL" to private from readable by the public; this can now be configured per instance of the S3 adapter