Skip to content

fix: install npm in docker containers#6

Merged
joostfaassen merged 1 commit intolinkorb:masterfrom
mhitza:fix-install-missing-npm
Dec 30, 2023
Merged

fix: install npm in docker containers#6
joostfaassen merged 1 commit intolinkorb:masterfrom
mhitza:fix-install-missing-npm

Conversation

@mhitza
Copy link
Copy Markdown
Contributor

@mhitza mhitza commented Dec 30, 2023

Missing npm has to deal with the underlying debian container, and the way that the third-party repository sometimes isn't picked up (by my understanding it has to do with version overlap). The upgrade to the node major version fixes this issue across both images, while an explicit apt-get install npm works only within the php8 container.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types

Please indicate if your PR introduces a breaking change

  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Missing npm has to deal with the underlying debian container, and the
way that the third-party repository sometimes isn't picked up (by my
understanding it has to do with version overlap). The upgrade to the
node major version fixes this issue across both images, while an
explicit `apt-get install npm` works only within the php8 container.
@joostfaassen joostfaassen merged commit 48653a4 into linkorb:master Dec 30, 2023
@mhitza mhitza deleted the fix-install-missing-npm branch January 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants