fix #36 & add GitHub workflow#38
Merged
Merged
Conversation
Author
|
any chance of getting this merged. Happy to make changes if needed. The deprecation still needs to be resolved |
Author
|
Cool thanks. The macos builds should probably be removed until DMD supports arm. Glad to see this get merged |
Owner
|
That's true for DMD on Mac. LDC on Mac however compiles and runs, but fails. Also, the test result looks strange: there are more than two unit tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note that the MacOS build fails due to #37
See https://github.com/SingingBush/dunit/actions/runs/7184674452 for result of the workflow running on my fork