Merged
Conversation
- Move satpy YAML configs from resources/ to src/satctl/_config_data/ - Add automatic SATPY_CONFIG_PATH setup in package initialization - Make yaml_file path configurable in get_settings() function - Remove hardcoded yaml_file from SatCtlSettings model config - Clean up trailing whitespace in config files
…r pattern Implements lazy initialization pattern for authenticators and downloaders using factory builders, improving configuration flexibility and dependency management. Key changes: - Replace direct instantiation with AuthBuilder and DownloadBuilder factories - Move authenticator/downloader initialization to point of use (lazy init) - Rename config keys: `authenticator` → `default_authenticator`, `downloader` → `default_downloader` - Add SATCTL_CONFIG environment variable support in config loader - Simplify CLI by removing explicit downloader creation - Move downloader init parameter to include authenticator argument - Update all sources (S1, S2, S3, MODIS, VIIRS, MTG) to use new builder pattern - Move pytest log disable flags from pyproject.toml to Makefile - Make download/auth/sources dicts optional with empty defaults Breaking changes: - Config file format updated (authenticator/downloader → default_*) - Source creation API changed (no longer accepts authenticator parameter) - Downloader.init() signature changed (now requires authenticator)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.