Add Vancouver City API Integration for Facility Import#221
Merged
Conversation
… API - Implement VancouverApiClient for interacting with the Vancouver Open Data API. - Create VancouverApiConfig for configuration management including base URL and timeouts. - Add FaradayAdapter for HTTP requests with customizable options. - Implement dataset retrieval methods: get_dataset, get_datasets, get_dataset_records, and get_dataset_record. - Introduce error handling with custom VancouverApiError class for better error reporting. - Add comprehensive RSpec tests for client creation, dataset APIs, error handling, and request structure. - Include shared helpers for mocking responses in tests.
…for better API management
…nsure verified status is set to true
…k external_id assignment
…related logging and API call references
- Implement integration scenarios for comprehensive and minimal facility data. - Add edge case tests for special characters and edge coordinates. - Simulate concurrent operations and verify data consistency. - Create internal update operation tests to handle service synchronization. - Introduce operation detection tests to determine create, external_update, and internal_update operations. - Ensure result structure compliance with ApplicationService::Result. - Validate service synchronization logic for adding and maintaining services. - Handle edge cases for service creation and duplication gracefully.
…or consistency and update related specs
…uilder and FacilitySyncer
fabionl
added a commit
that referenced
this pull request
Jul 1, 2025
* Add local port mapping for Postgres and enhance logging in data rake task * Fix migrations (#219) * Add local port mapping for Postgres and enhance logging in data rake task * Fix facility suitability migration (cherry picked from commit e82d4f4) * Fix Puma configuration to disable workers in development and ensure proper preloading * Fix facilities fake data generation * Fix admin root route to point directly to the dashboard controller * Fix ChangeAllSuitabilityPermutations migration * Fix migration to use MigrationFacility class for updating welcomes (cherry picked from commit 4ffe866) * Fix migration to use MigrationFacility class for updating zone references (cherry picked from commit 7527626) * Fix migration to use MigrationFacility class for importing facility schedules (cherry picked from commit f8bd94a) * Add Vancouver City API Integration for Facility Import (#221) * Update database configuration to use environment variable for test database URL * Add VancouverApiClient and supporting classes for Vancouver Open Data API - Implement VancouverApiClient for interacting with the Vancouver Open Data API. - Create VancouverApiConfig for configuration management including base URL and timeouts. - Add FaradayAdapter for HTTP requests with customizable options. - Implement dataset retrieval methods: get_dataset, get_datasets, get_dataset_records, and get_dataset_record. - Introduce error handling with custom VancouverApiError class for better error reporting. - Add comprehensive RSpec tests for client creation, dataset APIs, error handling, and request structure. - Include shared helpers for mocking responses in tests. * Fix indentation for form_with in facilities index view * Refactor services structure for external services. * Refactor API handling in ToolsController and add External::ApiHelper for better API management * cleanup * Refactor FacilityBuilder * Update facility verification status to true for new imports * Add external_id field to Facility model and update FacilityBuilder to assign it * Refactor FacilityBuilder to streamline facility data extraction and ensure verified status is set to true * Fix facility building spec * Refactor FacilityBuilder geometry validation and update specs to check external_id assignment * Rename LIMIT to PAGE_SIZE for consistency in Syncer class and update related logging and API call references * Add integration and unit tests for Vancouver City FacilitySyncer - Implement integration scenarios for comprehensive and minimal facility data. - Add edge case tests for special characters and edge coordinates. - Simulate concurrent operations and verify data consistency. - Create internal update operation tests to handle service synchronization. - Introduce operation detection tests to determine create, external_update, and internal_update operations. - Ensure result structure compliance with ApplicationService::Result. - Validate service synchronization logic for adding and maintaining services. - Handle edge cases for service creation and duplication gracefully. * Refactor ResultData structure in FacilityBuilder and FacilitySyncer for consistency and update related specs * Add progress indicator and loading state for facility import form * Add service key mapping and update related specs for Vancouver City API integration * Add API key validation and remove redundant tests in FacilityServiceBuilder and FacilitySyncer * Update service parameter naming in facilities index * Fix redirect path for successful facility import in ToolsController * Fix FacilitySyncer specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds the ability for admins to import drinking fountain facilities from Vancouver City's Open Data API directly through the admin interface.
Key Business Logic
Import Process:
Data Mapping:
Create/Update Logic:
Key Decisions & Assumptions
Database Changes