Skip to content

Conversation

@0-sv
Copy link

@0-sv 0-sv commented May 20, 2021

Same as linode/apl-core#428, but for otomi-api.

Thanks @j-zimnowoda.

@0-sv 0-sv added the bug Something isn't working label May 20, 2021
@0-sv 0-sv requested review from Morriz and j-zimnowoda May 20, 2021 14:50
@0-sv 0-sv self-assigned this May 20, 2021
@0-sv
Copy link
Author

0-sv commented May 20, 2021

Do we need to add required: @j-zimnowoda? E.g.:

required:
  - vault

@Morriz Morriz self-requested a review May 26, 2021 13:12
Copy link
Contributor

@Morriz Morriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, when creating or updating schema always add title and definition for forms.

@0-sv
Copy link
Author

0-sv commented May 27, 2021

Please, when creating or updating schema always add title and definition for forms.

I share your concern, but my original intention was to address the issue that makes the "wrong" schema break our code.

Can we agree that I will add it to #172?

@Morriz

@0-sv 0-sv requested a review from Morriz May 27, 2021 10:14
@Morriz
Copy link
Contributor

Morriz commented May 30, 2021

Please, when creating or updating schema always add title and definition for forms.

I share your concern, but my original intention was to address the issue that makes the "wrong" schema break our code.

Can we agree that I will add it to #172?

@Morriz

Why postpone? What is wrong with always delivering schema with descriptions and titles?

@0-sv
Copy link
Author

0-sv commented Jun 1, 2021

Alright, it's just gonna be a copy and paste of the other PR...

@0-sv
Copy link
Author

0-sv commented Jun 1, 2021

I will actually close this PR so we don't have to go back and forth on schema changes....

@0-sv 0-sv closed this Jun 1, 2021
@Morriz Morriz deleted the chore/kms-schema branch June 2, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants