Skip to content

Conversation

@CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented Feb 7, 2025

  • Remove chai, Sinon, Mocha
  • Added Jest
  • Added jest-mock-extend (needed this to mock full objects, which is default in Sinon)

@CasLubbers CasLubbers requested review from ElderMatt, dennisvankekem and ferruhcihan and removed request for ferruhcihan February 11, 2025 10:34
@dennisvankekem dennisvankekem self-assigned this Feb 11, 2025
Copy link
Contributor

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean, all tests are passing and old testing dependancies seem to be removed.

Small nit, but there is still references to Mocha in launch.json and settings.json can they be removed?

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍🏻

@ferruhcihan ferruhcihan enabled auto-merge (squash) February 12, 2025 13:53
@ferruhcihan ferruhcihan merged commit 4cfaab9 into main Feb 12, 2025
2 checks passed
@ferruhcihan ferruhcihan deleted the APL-520 branch February 12, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants