Skip to content

fix: remove password from error log #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

fix: remove password from error log #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/otomi-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ export default class OtomiStack {
if (await this.repo.fileExists('env/cluster.yaml')) break
debug(`Values are not present at ${url}:${branch}`)
} catch (e) {
debug(`${e.message.trim()} for command ${JSON.stringify(e.task?.commands)}`)
// Remove password from error message
const safeCommand = JSON.stringify(e.task?.commands).replace(env.GIT_PASSWORD, '****')
debug(`${e.message.trim()} for command ${JSON.stringify(safeCommand)}`)
debug(`Git repository is not ready: ${url}:${branch}`)
}
const timeoutMs = 10000
Expand Down