Skip to content

Conversation

@ferruhcihan
Copy link
Collaborator

📌 Summary

This PR upgrades node version, replaces ts-node with tsx, upgrades kubernetes/client-node version and updates related functions/tests.

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.

dependabot bot and others added 11 commits June 24, 2025 09:42
Bumps [@kubernetes/client-node](https://github.com/kubernetes-client/javascript) from 0.22.1 to 1.3.0.
- [Release notes](https://github.com/kubernetes-client/javascript/releases)
- [Commits](kubernetes-client/javascript@0.22.1...1.3.0)

---
updated-dependencies:
- dependency-name: "@kubernetes/client-node"
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Coverage report

Caution

Multiple errors occurred

 1 | Error: The process '/usr/local/bin/npm' failed with exit code 1
 2 | Error: The process '/usr/local/bin/npm' failed with exit code 127
 3 | Coverage output file not found. (file "report.json" not found)
 4 | Getting code coverage data failed.
 5 | Error: The process '/usr/bin/git' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements 50.55% 2279/4508
🔴 Branches 35.28% 368/1043
🔴 Functions 42.55% 417/980
🔴 Lines 50.94% 2142/4205

Report generated by 🧪jest coverage report action from ba74aec

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only need to add this to the coverage job so you can merge it. This one now fails because we upgrade node:
continue-on-error: true

@ferruhcihan ferruhcihan merged commit 1b94c75 into main Jun 27, 2025
8 checks passed
@ferruhcihan ferruhcihan deleted the fc-maintenance branch June 27, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants