feat: add /v2/git & /v2/status endpoints#976
Open
CasLubbers wants to merge 15 commits intomainfrom
Open
Conversation
9 tasks
dennisvankekem
approved these changes
Apr 23, 2026
Contributor
dennisvankekem
left a comment
dennisvankekem
left a comment
There was a problem hiding this comment.
code looks good, and we've already pair tested it
ElderMatt
requested changes
Apr 28, 2026
| remoteHasContent = await req.otomi.git.testRemoteConnection(repoUrl, password, branch, username) | ||
| } catch (e: any) { | ||
| throw new BadRequestError(`Cannot connect to new git remote: ${e.message}`) | ||
| const error = { message: `Cannot connect to new git remote: ${e.message}`, statusCode: 404 } |
Contributor
There was a problem hiding this comment.
Should not throw a statuscode with 404, we dont get a statuscode from the git api, anything can go wrong. We should check if the message contains a certain phrase like does not exist and then pass along a 404 or something like that..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma:
https://www.figma.com/design/Y5Yuc40oWpPfQJBFLD25Bp/Configure-Git-Pop-Up-Modal?node-id=0-1&p=f&t=68Aiyz87HLp84Vto-0
console:
linode/apl-console#772
api:
#976