Skip to content

Comments

feat: add code repository page#512

Merged
ferruhcihan merged 30 commits intomainfrom
APL-512
Feb 24, 2025
Merged

feat: add code repository page#512
ferruhcihan merged 30 commits intomainfrom
APL-512

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Feb 12, 2025

Implements

https://jira.linode.com/browse/APL-512
https://docs.google.com/document/d/1hyJT-rKmz0RtN58fXQjNmgAB75B8wXpmXLos7kegX3o/edit?tab=t.0#heading=h.yufq4w75pww7

Description

This PR adds code repository page(s) created using the new form components.
Is paired with: linode/apl-api#628 and linode/apl-core#1945

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem dennisvankekem self-assigned this Feb 12, 2025
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first pass and I like the basics, however styling wise we need to add some finer details, I've created a frame comparison below with comments, please try to fix these styling issues on component level, I can help you if you want

https://www.figma.com/design/nAL8qBeyW41MqMxLAd2580/APL-512?node-id=0-1&p=f&t=UTnhYwT7gutxS1DM-0

@dennisvankekem
Copy link
Collaborator

Selected values and labels look like placeholder text, please adjust the colors

image

@dennisvankekem
Copy link
Collaborator

switching to Gitea service removes all the values from other tabs (not sure if we want to fix this now)

Screen.Recording.2025-02-17.at.3.15.19.PM.mov

@dennisvankekem
Copy link
Collaborator

Maybe a nit. But I can enter Gitlab url into Github service and vice versa, do we want to auto switch maybe?

@dennisvankekem
Copy link
Collaborator

I cannot select a secret? (I checked and it is synced in Argo) Do you have the same issue?

image

Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@ferruhcihan
Copy link
Collaborator Author

Selected values and labels look like placeholder text, please adjust the colors

Fixed!

@ferruhcihan
Copy link
Collaborator Author

switching to Gitea service removes all the values from other tabs (not sure if we want to fix this now)

This is intentional because if we don't remove the values, some fields (such as the secret name) might cause conflicts.

@ferruhcihan
Copy link
Collaborator Author

If I use capital letters in the Label then I get this error as opposed a form validation

Fixed! Added label field validation.

@ferruhcihan
Copy link
Collaborator Author

Maybe a nit. But I can enter Gitlab url into Github service and vice versa, do we want to auto switch maybe?

Fixed! Added repository url validation using git service.

@ferruhcihan
Copy link
Collaborator Author

I cannot select a secret? (I checked and it is synced in Argo) Do you have the same issue?

The secrets should be Sealed Secrets of type basic-auth or ssh-auth.

@dennisvankekem
Copy link
Collaborator

We should show a human readable error, this is one of the reasons we want static forms

image

@dennisvankekem
Copy link
Collaborator

filling out a Github URL at Gitlab is allowed and test connection works, but it doesn't switch the provider to Github

image

@dennisvankekem
Copy link
Collaborator

I can't connect to my private repo with SSH secret (perhaps I'm still doing something wrong?)

image

@ElderMatt
Copy link
Contributor

At the moment when testing on a cluster the tab looks like this.
image
and Text also look wrong.
image

I dont know if this is because I upgraded from a different branch to this branch.

@ferruhcihan
Copy link
Collaborator Author

We should show a human readable error, this is one of the reasons we want static forms

I added human readable error message

@ferruhcihan
Copy link
Collaborator Author

filling out a Github URL at Gitlab is allowed and test connection works, but it doesn't switch the provider to Github

Fixed! Improved the form validation.

@ferruhcihan
Copy link
Collaborator Author

I can't connect to my private repo with SSH secret (perhaps I'm still doing something wrong?)

Updated private repo connection and fixed the ssh connection issue.

@ferruhcihan
Copy link
Collaborator Author

At the moment when testing on a cluster the tab looks like this.
I dont know if this is because I upgraded from a different branch to this branch.

Yes, it's because of browser caching. If you still get this error, try the Empty Cache and Hard Reload option.

@ferruhcihan ferruhcihan merged commit 269d229 into main Feb 24, 2025
10 checks passed
@ferruhcihan ferruhcihan deleted the APL-512 branch February 24, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants