Skip to content

fix: enhance image repository handling for workloads #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferruhcihan merged 2 commits into from
Mar 25, 2026
Merged

fix: enhance image repository handling for workloads #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9d0bc
fix: enhance image repository handling for workloads
ferruhcihan Mar 24, 2026
e2dfae3
Merge remote-tracking branch 'origin/main' into APL-1735
svcAPLBot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Box, ButtonGroup, Typography } from '@mui/material'
import YAML from 'yaml'
import { omit } from 'lodash'
import { isEmpty, omit } from 'lodash'
import React, { useEffect, useMemo, useState } from 'react'
import { FormProvider, Resolver, useForm } from 'react-hook-form'
import { useTranslation } from 'react-i18next'
Expand Down Expand Up @@ -284,12 +284,24 @@ export default function WorkloadsCreateEditPage({

try {
const parsedValues = YAML.parse(workloadValuesYaml || '')
const imageRepository: string | undefined = parsedValues?.image?.repository
const tag: string | undefined = parsedValues?.image?.tag

// Search for image.repository in nested YAML structures (e.g. versionOne.image.repository in canary charts)
const findImageConfig = (obj: any, depth = 0): { repository?: string; tag?: string } | undefined => {
if (!obj || typeof obj !== 'object' || depth > 5) return undefined
if (obj.image?.repository) return { repository: obj.image.repository, tag: obj.image.tag }
return Object.keys(obj).reduce<{ repository?: string; tag?: string } | undefined>(
(found, key) => found ?? findImageConfig(obj[key], depth + 1),
undefined,
)
}

const imageConfig = findImageConfig(parsedValues)
const imageRepository = imageConfig?.repository
const tag = imageConfig?.tag

const selectedType = (imageUpdateStrategy as any)?.type as 'disabled' | 'digest' | 'semver' | undefined

if (imageRepository && selectedType === 'digest') {
if (!isEmpty(imageRepository) && selectedType === 'digest') {
const currentDigest = (imageUpdateStrategy as any)?.digest ?? {}
imageUpdateStrategy = {
type: 'digest',
Expand All @@ -302,7 +314,7 @@ export default function WorkloadsCreateEditPage({
}
}

if (imageRepository && selectedType === 'semver') {
if (!isEmpty(imageRepository) && selectedType === 'semver') {
const currentSemver = (imageUpdateStrategy as any)?.semver ?? {}
imageUpdateStrategy = {
type: 'semver',
Expand Down
Loading