Skip to content

feat: default disable egress policies for enterprise clusters#2619

Merged
j-zimnowoda merged 17 commits into
mainfrom
APL-1211
Oct 28, 2025
Merged

feat: default disable egress policies for enterprise clusters#2619
j-zimnowoda merged 17 commits into
mainfrom
APL-1211

Conversation

@Ani1357
Copy link
Copy Markdown
Contributor

@Ani1357 Ani1357 commented Oct 23, 2025

📌 Summary

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Comment thread helmfile.d/snippets/defaults.gotmpl Outdated
Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work when I specify

kind: AplCluster
metadata:
    name: cluster
spec:
    provider: linode
    linode:
        tier: enterprise

@Ani1357
Copy link
Copy Markdown
Contributor Author

Ani1357 commented Oct 28, 2025

Does not work when I specify

kind: AplCluster
metadata:
    name: cluster
spec:
    provider: linode
    linode:
        tier: enterprise

Be aware, if using the tests/fixtures, check that the specific team you are rendering does not set the networkPolicy.egressPublic = true since it will override the defaults.

@j-zimnowoda j-zimnowoda self-requested a review October 28, 2025 14:47
Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test fixtures

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) October 28, 2025 14:48
@j-zimnowoda j-zimnowoda merged commit d066ba1 into main Oct 28, 2025
11 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1211 branch October 28, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants