Conversation
Contributor
|
Comparison of Helm chart templating output: # apl-operator/templates/deployment.yaml
@@ spec.template.spec.containers.apl-operator @@
! + one map entry added:
+ command:
+ - node
+ - dist/src/operator/main.js
# ingress-nginx/templates/controller-configmap.yaml
@@ data @@
! - 13 map entries removed:
- enable-opentelemetry: "true"
- opentelemetry-config: /etc/nginx/opentelemetry.toml
- opentelemetry-operation-name: "HTTP $request_method $service_name $uri"
- opentelemetry-trust-incoming-span: "true"
- otel-max-export-batch-size: 512
- otel-max-queuesize: 2048
- otel-sampler: AlwaysOn
- otel-sampler-parent-based: "true"
- otel-sampler-ratio: 0.01
- otel-schedule-delay-millis: 5000
- otel-service-name: nginx-net-a
- otlp-collector-host: platform-otlp-collector.otel.svc
- otlp-collector-port: 4317
# ingress-nginx/templates/controller-configmap.yaml
@@ data @@
! - 13 map entries removed:
- enable-opentelemetry: "true"
- opentelemetry-config: /etc/nginx/opentelemetry.toml
- opentelemetry-operation-name: "HTTP $request_method $service_name $uri"
- opentelemetry-trust-incoming-span: "true"
- otel-max-export-batch-size: 512
- otel-max-queuesize: 2048
- otel-sampler: AlwaysOn
- otel-sampler-parent-based: "true"
- otel-sampler-ratio: 0.01
- otel-schedule-delay-millis: 5000
- otel-service-name: nginx-platform
- otlp-collector-host: platform-otlp-collector.otel.svc
- otlp-collector-port: 4317
# raw/templates/resources.yaml
@@ spec @@
! - one map entry removed:
- tracing:
- - providers:
- - name: otel-tracing
- randomSamplingPercentage: 0.01
# istiod/templates/configmap-values.yaml
@@ data.original-values @@
! ± value change in multiline text (no inserts, two deletions)
{
"autoscaleMax": 5,
"autoscaleMin": 1,
"env": {
[43 lines unchanged)]
}
},
"meshConfig": {
"accessLogFile": "/dev/stdout",
- "accessLogFormat": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% \"%UPSTREAM_TRANSPORT_FAILURE_REASON%\" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME% traceID=%REQ(TRACEPARENT)%\n",
"defaultConfig": {
"gatewayTopology": {
"numTrustedProxies": 1
},
"holdApplicationUntilProxyStarts": true
},
"enableAutoMtls": true,
"extensionProviders": [
- {
- "name": "otel-tracing",
- "opentelemetry": {
- "port": 4317,
- "service": "platform-otlp-collector.otel.svc.cluster.local"
- }
- },
{
"envoyExtAuthzHttp": {
"headersToDownstreamOnAllow": [
"set-cookie"
[47 lines unchanged)]
}
},
"revision": "1-26-0"
}
@@ data.merged-values @@
! ± value change in multiline text (no inserts, two deletions)
{
"affinity": {},
"autoscaleBehavior": {},
"autoscaleEnabled": true,
[171 lines unchanged)]
"keepaliveMaxServerConnectionAge": "30m",
"memory": {},
"meshConfig": {
"accessLogFile": "/dev/stdout",
- "accessLogFormat": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% \"%UPSTREAM_TRANSPORT_FAILURE_REASON%\" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME% traceID=%REQ(TRACEPARENT)%\n",
"defaultConfig": {
"gatewayTopology": {
"numTrustedProxies": 1
},
[one line unchanged)]
},
"enableAutoMtls": true,
"enablePrometheusMerge": true,
"extensionProviders": [
- {
- "name": "otel-tracing",
- "opentelemetry": {
- "port": 4317,
- "service": "platform-otlp-collector.otel.svc.cluster.local"
- }
- },
{
"envoyExtAuthzHttp": {
"headersToDownstreamOnAllow": [
"set-cookie"
[98 lines unchanged)]
"variant": "",
"volumeMounts": [],
"volumes": []
}
# istiod/templates/configmap.yaml
@@ data.mesh @@
! ± value change in multiline text (no inserts, two deletions)
accessLogFile: /dev/stdout
- accessLogFormat: |
- [%START_TIME%] "%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% "%UPSTREAM_TRANSPORT_FAILURE_REASON%" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% "%REQ(X-FORWARDED-FOR)%" "%REQ(USER-AGENT)%" "%REQ(X-REQUEST-ID)%" "%REQ(:AUTHORITY)%" "%UPSTREAM_HOST%" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME% traceID=%REQ(TRACEPARENT)%
defaultConfig:
discoveryAddress: istiod-1-26-0.istio-system.svc:15012
gatewayTopology:
numTrustedProxies: 1
[three lines unchanged)]
- prometheus
enableAutoMtls: true
enablePrometheusMerge: true
extensionProviders:
- - name: otel-tracing
- opentelemetry:
- port: 4317
- service: platform-otlp-collector.otel.svc.cluster.local
- envoyExtAuthzHttp:
headersToDownstreamOnAllow:
- set-cookie
headersToDownstreamOnDeny:
[23 lines unchanged)]
interval: 5s
probes: 3
time: 10s
trustDomain: cluster.local
# raw/templates/resources.yaml
@@ (root level) @@
# rbac.authorization.k8s.io/v1/ClusterRoleBinding/platform-otlp-collector
! - one document removed:
- ---
- # Source: raw/templates/resources.yaml
- apiVersion: rbac.authorization.k8s.io/v1
- kind: ClusterRoleBinding
- metadata:
- name: platform-otlp-collector
- labels:
- app: raw
- app.kubernetes.io/instance: otel-operator-artifacts
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/name: raw
- app.kubernetes.io/part-of: otomi
- app.kubernetes.io/version: 0.2.3
- helm.sh/chart: raw-0.2.3
- roleRef:
- name: otel-collector
- apiGroup: rbac.authorization.k8s.io
- kind: ClusterRole
- subjects:
- - name: platform-otlp-collector
- kind: ServiceAccount
- namespace: otel
@@ (root level) @@
# opentelemetry.io/v1beta1/OpenTelemetryCollector/platform-otlp
! - one document removed:
- ---
- # Source: raw/templates/resources.yaml
- apiVersion: opentelemetry.io/v1beta1
- kind: OpenTelemetryCollector
- metadata:
- name: platform-otlp
- labels:
- app: raw
- app.kubernetes.io/instance: otel-operator-artifacts
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/name: raw
- app.kubernetes.io/part-of: otomi
- app.kubernetes.io/version: 0.2.3
- helm.sh/chart: raw-0.2.3
- spec:
- resources:
- limits:
- cpu: 500m
- memory: 128Mi
- requests:
- cpu: 100m
- memory: 64Mi
- managementState: managed
- mode: deployment
- autoscaler:
- maxReplicas: 6
- minReplicas: 2
- targetCPUUtilization: 80
- targetMemoryUtilization: 80
- config:
- exporters:
- debug: {}
- processors:
- batch:
- send_batch_size: 10000
- timeout: 10s
- k8sattributes:
- auth_type: serviceAccount
- extract:
- metadata:
- - k8s.pod.name
- - k8s.pod.uid
- - k8s.deployment.name
- - k8s.namespace.name
- - k8s.node.name
- - k8s.pod.start_time
- passthrough: false
- memory_limiter:
- check_interval: 1s
- limit_percentage: 75
- spike_limit_percentage: 15
- receivers:
- otlp:
- protocols:
- grpc: {}
- http: {}
- service:
- pipelines:
- logs:
- exporters:
- - debug
- processors:
- - batch
- receivers:
- - otlp
- traces:
- exporters:
- - debug
- processors:
- - memory_limiter
- - batch
- - k8sattributes
- receivers:
- - otlp
# otomi-api/templates/configmap.yaml
@@ data.VERSIONS @@
! ± value change in multiline text (one insert, one deletion)
- {"api":"APL-523","aplCharts":"main","console":"APL-523","consoleLogin":"APL-523","core":"main","specVersion":61,"tasks":"APL-523","tools":"main"}
+ {"api":"APL-523","aplCharts":"main","console":"APL-523","consoleLogin":"APL-523","core":"main","specVersion":62,"tasks":"APL-523","tools":"main"}
# otomi-api/templates/deployment.yaml
# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml
# Old file deleted: team-ns/templates/telemetry
# Old file deleted: team-ns/templates/telemetry
# Old file deleted: team-ns/templates/telemetry
# values-repo.yaml
@@ apps @@
! - one map entry removed:
- ingress-nginx:
- resources:
- controller:
- limits:
- cpu: 2
- memory: 2Gi
- requests:
- cpu: 100m
- memory: 384Mi
- defaultBackend:
- limits:
- cpu: 20m
- memory: 20Mi
- requests:
- cpu: 10m
- memory: 10Mi
- opentelemetry:
- limits:
- cpu: 500m
- memory: 256Mi
- requests:
- cpu: 100m
- memory: 65Mi
- _rawValues: {}
- maxBodySize: 1024m
- maxBodySizeBytes: 1073741824
- autoscaling:
- enabled: true
- maxReplicas: 10
- minReplicas: 2
- targetCPUUtilizationPercentage: 80
- targetMemoryUtilizationPercentage: 80
- modsecurity:
- block: false
- enabled: false
- owasp: true
- tracing:
- enabled: false
- samplingRatio: 0.01
@@ apps.ingress-nginx-net-a @@
! - one map entry removed:
- tracing:
- enabled: true
- samplingRatio: 0.01
@@ apps.ingress-nginx-platform @@
! - one map entry removed:
- tracing:
- enabled: true
- samplingRatio: 0.01
@@ apps.istio @@
! - one map entry removed:
- tracing:
- enabled: true
- samplingRatio: 0.01
@@ apps.otel @@
! - one map entry removed:
- otlpCollector:
- attributes:
- - k8s.pod.name
- - k8s.pod.uid
- - k8s.deployment.name
- - k8s.namespace.name
- - k8s.node.name
- - k8s.pod.start_time
- autoscaler:
- maxReplicas: 6
- minReplicas: 2
- targetCPUUtilizationPercentage: 80
- targetMemoryUtilizationPercentage: 80
- mode: deployment
@@ apps.otel.resources @@
! - one map entry removed:
- otlpCollector:
- limits:
- cpu: 500m
- memory: 128Mi
- requests:
- cpu: 100m
- memory: 64Mi
@@ versions.specVersion @@
! ± value change
- 61
+ 62
|
CasLubbers
approved these changes
Apr 13, 2026
ElderMatt
approved these changes
Apr 16, 2026
Contributor
ElderMatt
left a comment
There was a problem hiding this comment.
Dont forget to update the version change to 61
# Conflicts: # src/cmd/migrate.ts # tests/fixtures/env/settings/versions.yaml # values-changes.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is a follow-up from removing Tempo. There is no more backend in the platform for tracing. The OTLP collector would at this point still gather logs from connected workloads and Istio, but just log them to stdout. Distributed tracing needs to be redesigned with Istio ambient mesh and the Gateway API.
🔍 Reviewer Notes
🧹 Checklist