Skip to content

feat: add app label to http route#3190

Merged
merll merged 6 commits intomainfrom
APL-1831
Apr 29, 2026
Merged

feat: add app label to http route#3190
merll merged 6 commits intomainfrom
APL-1831

Conversation

@j-zimnowoda
Copy link
Copy Markdown
Contributor

@j-zimnowoda j-zimnowoda commented Apr 29, 2026

📌 Summary

Unify HTTPRoute labels.

Depends-on: linode/apl-api#985

🔍 Reviewer Notes

HTTPRoute for ksvc is managed by ksvc serving.

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@svcAPLBot
Copy link
Copy Markdown
Contributor

svcAPLBot commented Apr 29, 2026

Comparison of Helm chart templating output:

# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml

# team-ns/templates/routes.yaml

@@ metadata.name @@
# networking.istio.io/v1/ServiceEntry/hello-admin-internal
! ± value change
- hello-admin-admin-internal
+ hello-admin-internal

@@ metadata @@
# gateway.networking.k8s.io/v1/HTTPRoute/hello-admin
! + one map entry added:
+ labels:
+   otomi.io/app: hello-admin

@@ metadata.name @@
# gateway.networking.k8s.io/v1/HTTPRoute/hello-admin
! ± value change
- hello-admin-admin
+ hello-admin

# team-ns/templates/routes.yaml

@@ spec.parentRefs.net-a-workloads.sectionName @@
# gateway.networking.k8s.io/v1/HTTPRoute/net-a-http-https-redirect
! ± value change
- http-cname-service-e-demo
+ http-cname-service-e

@@ spec.listeners @@
# gateway.networking.x-k8s.io/v1alpha1/XListenerSet/net-a-workloads
! - two list entries removed:
- - name: http-cname-service-e-demo
-   hostname: net-a-demo.cname.com
-   protocol: HTTP
-   port: 80
-   allowedRoutes:
-     namespaces:
-       from: Same
- - name: https-cname-service-e-demo
-   hostname: net-a-demo.cname.com
-   protocol: HTTPS
-   port: 443
-   tls:
-     certificateRefs:
-     - name: net-a-cname
-   allowedRoutes:
-     namespaces:
-       from: Same
! + two list entries added:
+ - name: http-cname-service-e
+   hostname: net-a-demo.cname.com
+   protocol: HTTP
+   port: 80
+   allowedRoutes:
+     namespaces:
+       from: Same
+ - name: https-cname-service-e
+   hostname: net-a-demo.cname.com
+   protocol: HTTPS
+   port: 443
+   tls:
+     certificateRefs:
+     - name: net-a-cname
+   allowedRoutes:
+     namespaces:
+       from: Same

@@ metadata @@
# gateway.networking.k8s.io/v1/HTTPRoute/service-e
! + one map entry added:
+ labels:
+   otomi.io/app: service-e

@@ metadata.name @@
# gateway.networking.k8s.io/v1/HTTPRoute/service-e
! ± value change
- service-e-demo
+ service-e

@@ metadata.name @@
# networking.istio.io/v1/ServiceEntry/service-e-internal
! ± value change
- service-e-demo-internal
+ service-e-internal

@@ metadata.name @@
# networking.istio.io/v1/ServiceEntry/service-a-internal
! ± value change
- service-a-demo-internal
+ service-a-internal

@@ metadata.name @@
# networking.istio.io/v1/ServiceEntry/has-cert-svc-internal
! ± value change
- has-cert-svc-demo-internal
+ has-cert-svc-internal

@@ metadata @@
# gateway.networking.k8s.io/v1/HTTPRoute/service-a
! + one map entry added:
+ labels:
+   otomi.io/app: service-a

@@ metadata.name @@
# gateway.networking.k8s.io/v1/HTTPRoute/service-a
! ± value change
- service-a-demo
+ service-a

@@ metadata @@
# gateway.networking.k8s.io/v1/HTTPRoute/hello-blue-green
! + one map entry added:
+ labels:
+   otomi.io/app: hello-blue-green

@@ metadata.name @@
# gateway.networking.k8s.io/v1/HTTPRoute/hello-blue-green
! ± value change
- hello-blue-green-demo
+ hello-blue-green

@@ metadata.name @@
# networking.istio.io/v1/ServiceEntry/hello-blue-green-internal
! ± value change
- hello-blue-green-demo-internal
+ hello-blue-green-internal

@@ metadata @@
# gateway.networking.k8s.io/v1/HTTPRoute/has-cert-svc
! + one map entry added:
+ labels:
+   otomi.io/app: has-cert-svc

@@ metadata.name @@
# gateway.networking.k8s.io/v1/HTTPRoute/has-cert-svc
! ± value change
- has-cert-svc-demo
+ has-cert-svc

# values-repo.yaml

Comment thread charts/team-ns/templates/routes.yaml Outdated
Co-authored-by: merll <merll@users.noreply.github.com>
@merll merll merged commit 51a4367 into main Apr 29, 2026
14 checks passed
@merll merll deleted the APL-1831 branch April 29, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants