fix: pvc migration for the gitea-gitea-valkey#3234
Merged
Conversation
merll
reviewed
May 12, 2026
merll
reviewed
May 12, 2026
merll
requested changes
May 12, 2026
Collaborator
merll
left a comment
merll
left a comment
There was a problem hiding this comment.
I have concerns that while solving this particular issue this implementation will cause another one in following releases.
merll
approved these changes
May 12, 2026
ferruhcihan
added a commit
that referenced
this pull request
May 28, 2026
Co-authored-by: svcAPLBot <174728082+svcAPLBot@users.noreply.github.com> (cherry picked from commit d5e2636)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR fixes the PVC migration for the
gitea-gitea-valkey.LKE Enterprise upgrade from
v4.15.3tov5.0.0could leave Gitea unavailable due to ArgoCD sync being permanently disabled. Enterprise clusters uselinode-block-storage-retainas the default StorageClass, which triggers a PVC migration that disables ArgoCD sync forgitea-gitea-valkey. The sync was never re-enabled becauseapplyAll()exited early before reachingapplyAsAppswhen an operator version change was detected.The issue is fixed by making the migration idempotent on re-runs, and throwing on timeout instead of silently continuing during the migration.
🔍 Reviewer Notes
🧹 Checklist