fix: Check Image upload size before attempting upload#251
Merged
Conversation
Closes #250 Right now, the `image-upload` plugin just attempts to upload whatever it's given, but that can waste a lot of time. This change checks that the compressed size is no larger than the maximum allowed (5GB) before initiating the upload. This change does not attempt to catch cases where the _uncompressed_ size of the image is larger than allowed; the maximum uncompressed size is not constant, and the CLI has no way to know if an Image uploaded will end up being too large when it gets there.
patthiel
reviewed
Jul 13, 2021
alsaihn
approved these changes
Jul 13, 2021
patthiel
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250
Right now, the
image-uploadplugin just attempts to upload whateverit's given, but that can waste a lot of time.
This change checks that the compressed size is no larger than the
maximum allowed (5GB) before initiating the upload.
This change does not attempt to catch cases where the uncompressed
size of the image is larger than allowed; the maximum uncompressed size
is not constant, and the CLI has no way to know if an Image uploaded
will end up being too large when it gets there.