new: Add support for explicit nullable arguments #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
approved these changes
Mar 28, 2023
jriddle-linode
approved these changes
May 26, 2023
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
Changes look good, will require a couple small changes to spec parser PR but nothing major. Good to merge before parser IMO.
yec-akamai
approved these changes
Jul 21, 2023
Member
|
Any update on this? @lgarber-akamai |
Contributor
Author
|
@zliang-akamai I plan on updating and re-requesting reviews on this once the OpenAPI spec has been merged to main 👍 |
lgarber-akamai
force-pushed
the
new/add-support-for-nullable-strings
branch
from
febca0b to
ba557fa
Compare
zliang-akamai
approved these changes
Aug 11, 2023
Member
zliang-akamai
left a comment
zliang-akamai
left a comment
There was a problem hiding this comment.
The refactoring was awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change allows users to specify
nullas a value for fields that are marked asnullablein the API spec. This is useful for situations where the API may have certain functionality tied to having a certain value be explicitlynull(e.g. RDNS resets)e.g.
NOTE: This will need to be partially reworked after the spec parser refactor, but the change should be relatively straightforward.
Resolves #266
✔️ How to Test