Add --all-rows Flag
#455
Merged
Add --all-rows Flag
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
force-pushed
the
zhiwei/all-rows
branch
from
e02edae to
ebe5bc5
Compare
zliang-akamai
force-pushed
the
zhiwei/all-rows
branch
from
916fd7a to
69b8fdf
Compare
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
zliang-akamai
force-pushed
the
zhiwei/all-rows
branch
from
69b8fdf to
efedf30
Compare
lgarber-akamai
requested changes
May 18, 2023
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Works as expected on my end. One small change and we should be good to go 👍
ezilber-akamai-zz
approved these changes
May 22, 2023
Contributor
ezilber-akamai-zz
left a comment
ezilber-akamai-zz
left a comment
There was a problem hiding this comment.
LGTM! Good work!
lgarber-akamai
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Provide a option for user to output all results without pagination.
Should we add some integration/unit tests for this? Will be working on that if necessary.
✔️ How to Test
Create 1000 stackscripts in your account then run
linode --all-rows stackscripts ls --is_public false