-
Notifications
You must be signed in to change notification settings - Fork 152
test: Add workflow for Windows #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ykim-akamai
merged 33 commits into
linode:dev
from
ykim-akamai:test/window_gha_compatibility
Jun 1, 2023
Merged
test: Add workflow for Windows #461
ykim-akamai
merged 33 commits into
linode:dev
from
ykim-akamai:test/window_gha_compatibility
Jun 1, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/wintest sha=f8bb8e37ec60a73fa98282c14930d421e4dd3f94 |
Contributor
Author
|
/wintest sha=fa92e696db88bc9b7b08d934f0f37f01ae92fcf3 |
lgarber-akamai
requested changes
May 25, 2023
Contributor
lgarber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just one small code suggestion and we should be good to go
lgarber-akamai
approved these changes
May 30, 2023
…nto test/window_gha_compatibility
zliang-akamai
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
✔️ How to Test
Unit tests are executed upon push
Integration tests run via /acctest command
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.