Dockerfile upgrade and BATS test related Dockerfiles and scripts cleanup #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
force-pushed
the
zhiwei/release-cleanup-and-upgrade
branch
from
f3ecc5c to
9d198c8
Compare
zliang-akamai
changed the title
Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
lgarber-akamai
approved these changes
Jun 29, 2023
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Image is down to 285MB, nice work!
zliang-akamai
changed the title
zliang-akamai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The based image of the docker files are outdated. And some older docker files are no longer used. We should cleanup the unused ones and upgrade the useful one(s).
✔️ How to Test
GITHUB_TOKENwith the basic read public repo scope andLINODE_TOEKNin the env.docker build --build-arg="github_token=$GITHUB_TOKEN" .docker images, then copy the most recent image ID built by step 2.docker run --rm -it -e LINODE_CLI_TOKEN=$LINODE_TOKEN the_image_id linodes list