Skip to content

Conversation

@lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Jul 14, 2023

📝 Description

This change allows for the API target to be overridden through entries in the config file. These fields can be configured during the linode-cli configure process.

Additionally, this change introduces helpers for boolean and text inputs during the configuration process.

This PR also fixes a few bugs and broken tests I discovered in the openspec branch. This includes a bug that would break request URLs when a custom api_version is specified.

✔️ How to Test

make testunit

@lgarber-akamai lgarber-akamai marked this pull request as ready for review July 25, 2023 17:33
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner July 25, 2023 17:33
@jriddle-linode jriddle-linode requested a review from a team July 25, 2023 18:17
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lgarber-akamai lgarber-akamai merged commit a899499 into linode:openspec Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants